Skip to content

propagate database.DB up to NewSchema

Warren Gifford requested to merge backend-integration/cc/propagate-new-db into main

Created by: camdencheek

This PR propagates the new database.DB up the call chain from my test usage of it in RepoResolver all the way up the direct call chain to NewSchema. This allows me to start propagating it back down the call tree as I update tests to avoid using the global mocks.

Each commit is one step in the propagation process (mostly for my own sanity), but you'll see that this is almost entirely just "rename dbutil.DB to database.DB, or wrap a passed-in DB with database.NewDB()". This works because database.DB currently embeds dbutil.DB. All the calls to database.NewDB() currently break the mock call chain, so the goal is to instantiate the database.DB at the very top of the call tree, then never convert it back to a dbutil.DB.

Progresses #26113

Merge request reports