Skip to content
Snippets Groups Projects

codeintel: API docs: wrap upload handling in a panic handler

Merged Warren Gifford requested to merge sg/apidocs-panic-handler into main

Created by: slimsag

WriteDocumentationPages is by far the most complex code path in the API docs logic, and it relies on a lot of concurrency / channels logic which is itself even more complex (see group_documentation.go).

It stands to reason that the biggest risk API docs could impose would be a bug failing to handle a specific LSIF bundle or similar. In this situation, I'd really rather not fail the entire LSIF upload. It'd be better if only API docs failed.

This achieves that by adding a panic handler for that code.

This prevents issues like https://github.com/sourcegraph/sourcegraph/issues/26218#issuecomment-946053814 from impacting LSIF uploads.

Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com

Merge request reports

Merged by avatar (May 6, 2025 4:42pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading