Skip to content

remove stdout/stderr redirection from jaeger

Warren Gifford requested to merge cc/fix-unkillable-jaeger into main

Created by: camdencheek

This commit removes the redirection of stdout/stderr from jaeger when running in sg. This was causing the bash process that spawned jaeger to stick around as its parent process, which would catch the kill signal from a canceled context and not kill its child jaeger process. This caused jaeger to not be cleaned up on a failed sg start or a panic, which meant it had to be manually killed if you wanted to restart.

Fixes #25537 (closed)

Also, #25537 (closed) mentions a couple of alternatives to this. I tried it out, and didn't see any jaeger logs after startup, so this felt like the most reasonable solution, but if people are attached to a separate log file, it might be worth looking at some other solutions.

Merge request reports

Loading