Skip to content
Snippets Groups Projects

codeintel: add support for find-implementations

Merged Warren Gifford requested to merge codeintel-support-implementations into main

Created by: chrismwendt

This adds find-implementations to the precise code intel backend. This is part of https://github.com/sourcegraph/sourcegraph/issues/24479

CleanShot 2021-10-17 at 20 14 00@2x

Walkthrough of the feature and code changes: video :movie_camera: I forgot to cover query_references.go in the video, but it contained mostly refactors like inlining pageReferences and renaming cursor fields.

TODO

  • Create an implements graphql resolver
  • Implement the bulk of the backend changes
  • Implement find-references in the LSIF backend
  • Wire implementations through the extension host
  • Update https://docs.sourcegraph.com/extensions/authoring/context_key_expressions#available-context-keys
  • Support cross-repo find-implementations
  • Add tests
  • Make sure a context key is set when there is a definition so that the extension can use it in the when expression to toggle the "Find implementations" button
  • Fix nondeterministic LSIF diff test

Merge request reports

Merged by avatar (May 6, 2025 4:20pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading