web: fix `webpack-dev-server` configuration (!24377) · Merge requests · Warren Gifford / sourcegraph · GitLab

Warren Gifford requested to merge vb/webpack-ds-types into sqs/webpack-ds-types Aug 27, 2021

Created by: valerybugakov

Context

Additions to https://github.com/sourcegraph/sourcegraph/pull/24369 to fix sg run web, which failed with an invalid configuration error:

Screenshot 2021-08-27 at 15 38 12

Changes

The migration guide was used to add missing fields to the configuration.
To avoid fixing non-existent problems, this PR also upgrades webpack-dev-server to the stable v4 release.

Notes

Removes unneeded (and removed) firewall option. (This was renamed to allowedHosts, but the default is no firewall.)

For some reason running sg run enterprise-web-standalone resulted in invalid host header without allowedHosts configuration.

Part of https://github.com/sourcegraph/sourcegraph/issues/22832.