Skip to content

cherry-pick: Deploy to dotcom

Warren Gifford requested to merge ig/cherry-pick into release/2021-08-19

Created by: indradhanush

What

A list of cherry picked commits from main that need to be deployed to dotcom.

Here is a list of original PRs that introduced them into main:

#24071: PR that reduces noise of the repo-updater alerts. At the moment the alerts are firing multiple times throughout the day (and night) and have more noise than signal. The alerts stem from errors in repo-updater mostly due to failed repo lookups.

#24137: Fix to handle failed repo-lookups where repo names like github.com.example.com/foo/bar are incorrectly identified as the GitHub code host, ultimately leading to the errors which cause the repo-updater alerts to fire. This is an edge case that our previous approach missed.

#24144: Improvement on the fix for the errors to handle edge cases where / might be present in the URL args of repo names.

Why

  1. Noisy alerts with little signal -> Disturbed sleep over the weekend -> Unhappy on-call engineer (me) -> Unproductive upcoming week

  2. Noisy alerts with little signal -> Ignored because noisy -> Cry Wolf scenario when an alert might be legit but gets ignored because of prior events

Risks of regression in dotcom

None.

Confidence

High.

Merge request reports