Skip to content

LSIF: GraphQL: fix directory/tree resolver confusion and conflicts

Warren Gifford requested to merge sg/apidocs-resolvers into main

Created by: slimsag

This PR basically:

  • Clarifies WTF TreeEntryLSIFData actually is, I assumed tree == directory but that is not at all true, it's actually any file/directory. Document this.
  • Make GitTree.lsif return a GitTreeLSIFData resolver, instead of the "super" type TreeEntryLSIFData. Right now, this requires copying all methods of TreeEntryLSIFData into GitTreeLSIFData. In the next PR I send, this will enable me to instead have these methods defined only on GitTreeLSIFData (directory-specific) instead of BOTH on TreeEntryLSIFData and GitBlobLSIFData.
  • Also clarify other confusions I had with comments.

Merge request reports