Skip to content

API docs: LSIF: adjust definition ranges / fix incorrect references

Warren Gifford requested to merge sg/apidocs-invalid-refs into main

Created by: slimsag

Some usage examples / references were incorrectly reporting other random symbols:

image

After investigating, the DocumentationDefinition request definitely produces the right location for the definition - exactly the same location that we send in a regular graphql?References request - which introduced the question "why are our references wrong, then?"

The only difference is that in the definition resolution code in DocumentationReferences, I did not previously adjustLocations. That seems obviously wrong, and a likely cause - so here I fix that.

I suspect it'll fix the issue, but I don't have confirmation yet.

Fixes #23376 (closed)

Signed-off-by: Stephen Gutekanst [email protected]

Merge request reports