Skip to content

search: don't depend on searchResolver Query value at eval time

Warren Gifford requested to merge backend-dry-run/rvt/dont-set-resolver-query into main

Created by: rvantonder

Stacked on https://github.com/sourcegraph/sourcegraph/pull/22707.

No need to set r.Query for downstream evaluation any more.

Side note: We still need r.Query for suggestions and some other things like stats, but I believe those are evaluated separately along a different GQL point and doesn't depend on the state being set (and now removed) here. I will focus attention there later, right now I want our core search evaluation to support native Zoekt query evaluation ASAP.

Merge request reports