Skip to content
Snippets Groups Projects

add repo rev to predicate evaluation

Merged Warren Gifford requested to merge backend-dry-run/cc/predicate-repo-revs into main

Created by: camdencheek

Previously, if a predicate evaluated to a match with a specific repo rev, the rev would not be added to the expanded query. In practice, I don't think this could ever be hit because, if a repo rev was specified, the rev filter would apply after the predicate was evaluated as well, returning only results that matched the predicate-evaluated repo and the original revision-narrowed repo.

That said, there may be cases in the future where predicates can evaluate to specific revisions of a repo, and fixing this now will save some headaches down the road.

RE: https://github.com/sourcegraph/sourcegraph/pull/22666#discussion_r666037596

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading