Skip to content

Fix oval loading spinners on search page

Warren Gifford requested to merge pdubroy/22287-oval-icon into main

Created by: pdubroy

Fix #22287 (closed) - oval landing spinners on sourcegraph.com/search. Seems to be caused by the smaller size for inline icons in the redesign, interacting with margin on the loading spinner itself.

Putting icon-inline on the LoadingSpinner itself fixes the problem and seems to be the common way that we use the loading spinner (see here).

New behavior

https://user-images.githubusercontent.com/17293/123288334-c4540b00-d50f-11eb-971a-398aa1af3388.mp4

Merge request reports

Loading