Skip to content

precise-code-intel-tester: do not make unnamed GraphQL requests

Warren Gifford requested to merge sg/codeintel-unnamed-graphql into main

Created by: slimsag

Prior to this change, precise-code-intel-tester would make unnamed GraphQL requests which were impossible to identify in Grafana - and also spam the logs with unnamed GraphQL request logs:

10:06:38                  frontend | logging complete query for unnamed GraphQL request above name=unknown user=slimsag source=other:
10:06:38                  frontend | QUERY
10:06:38                  frontend | -----
10:06:38                  frontend | {
10:06:38                  frontend | 	r0: repository(name: "github.com/sourcegraph-testing/tidb") {
10:06:38                  frontend | 		codeIntelligenceCommitGraph {
10:06:38                  frontend | 			stale
10:06:38                  frontend | 		}
10:06:38                  frontend | 	}
10:06:38                  frontend | }
10:06:38                  frontend | VARIABLES
10:06:38                  frontend | ---------
10:06:38                  frontend | map[]

Every GraphQL request that comes from software Sourcegraph writes should include a ?QueryName to identify the type of request being made: it helps monitoring, it eliminates log verbosity.

Signed-off-by: Stephen Gutekanst [email protected]

Merge request reports