Skip to content

activation status in pings

Warren Gifford requested to merge onboarding-pings into master

Created by: dadlerj

WIP, needs testing. Initial items for https://github.com/sourcegraph/sourcegraph/issues/2024

Needs to differentiate between go-to-def and find-refs per convo here https://docs.google.com/a/sourcegraph.com/document/d/1P7uMHtOeYK1IwMj-1WtKspo16v8C_Mevj3qe1cX_kGY/edit?disco=AAAACjsSStE

Probably not currently the best way to record "did ever search" or "did ever do find refs" in redis, need to discuss what the ideal future activation dataset in pings is so this PR prepares us for that.

@sqs this is currently working, except find-refs isn't differentiated from go-to-def. We can merge this now, though, before 3.0, and while we'll potentially capture slightly too many that have used find-refs (since go-to-defs will also count), this can be fixed before 3.0.1.

Edit: looks like 3.0 is already tagged 🙁 this will have to get in in 3.0.1. Still ready for review, I will try to do the find-refs/go-to-def differentiation in a separate PR

Merge request reports