Skip to content

Provide link to code host if changeset is already published

Warren Gifford requested to merge kr/preview-link-to-codehost into main

Created by: courier-new

Closes #19607 (closed)!

Before: Screen Shot 2021-05-10 at 2 48 16 PM

After: Screen Shot 2021-05-10 at 3 47 23 PM

I'm not sure how to add "operations" (spec.operations) or change the title of a changeset (spec.delta.titleChanged) that comes back with the GraphQL response, but it appears that if we have either of those things on this node, we show the title with strikethrough. Since it only looks like we'd have this published changeset link on a VisibleApplyPreviewTargetsUpdate, I rearranged the conditionals a bit to accommodate this link in both the strikethrough and non-strikethrough styles. The strikethrough style looks like this:

Screen Shot 2021-05-10 at 3 59 39 PM

Since it's not entirely apparent to me what the strikethrough signifies, I'd love feedback on if having both the strikethrough and the link is too much.

Or, if you would have done something completely different here, I'd love to hear about that, too! I borrowed the styles/pattern from the ExternalChangesetInfoCell:

image

Merge request reports

Loading