Skip to content
Snippets Groups Projects

Upgrade aws-sdk-go-v2

Merged Warren Gifford requested to merge es/upgrade-aws-sdk-go-v2 into main

Created by: eseliger

This PR:

  • Migrates to the AWS v2 API in the codeintel s3 adapter
  • Upgrades the v2 package to the newest version

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff 28c81089e862636455b6c46e61b49a2c588a5a31...7c20ffbb560086f3b795e839ba787ff7e6a3b141.

    Notify File(s)
    @LawnGnome internal/extsvc/awscodecommit/client.go
    internal/extsvc/awscodecommit/codehost.go
    internal/extsvc/awscodecommit/repos.go
    @beyang enterprise/cmd/precise-code-intel-worker/main.go
    @christinaforney doc/dependency_decisions.yml
    @efritz enterprise/cmd/precise-code-intel-worker/main.go
    enterprise/internal/codeintel/stores/uploadstore/config_test.go
    enterprise/internal/codeintel/stores/uploadstore/mock_s3_api_test.go
    enterprise/internal/codeintel/stores/uploadstore/s3_api.go
    enterprise/internal/codeintel/stores/uploadstore/s3_client.go
    enterprise/internal/codeintel/stores/uploadstore/s3_client_test.go
  • Created by: efritz

    This may be a MinIO issue (filed here if so), or it could be an issue with the new Go SDK version that just happens to make invalid requests in a way that S3 leniently accepts.

    If MinIO claims it to be an issue with S3 we can follow up in another way.

  • Created by: efritz

    Fixes #19729 (closed).

Please register or sign in to reply
Loading