Skip to content

depgraph: Add additional lint passes

Warren Gifford requested to merge ef/depgraph-lints into main

Created by: efritz

$ go build && ./depgraph lint
error: 48 lint violations:

  1. <root>
     This package is not accessible to any repository-external project.
     This package is not imported by any binary defined in this repository.
     To resolve, delete this package (not including any existing child package).

  2. cmd/frontend/auth/providers
     The following 2 packages import this package across a command boundary.
     	- enterprise/internal/authz
	- internal/authz/gitlab
     To resolve, move this package to internal/.

  3. cmd/frontend/backend
     The following 10 packages import this package across a command boundary.
     	- enterprise/cmd/precise-code-intel-worker/internal/worker
	- enterprise/internal/batches/reconciler
	- enterprise/internal/batches/resolvers
	- enterprise/internal/batches/service
	- enterprise/internal/codemonitors
	- enterprise/internal/codemonitors/resolvers
	- enterprise/internal/codemonitors/storetest
	- enterprise/internal/insights/background/queryrunner
	- enterprise/internal/insights/resolvers
	- enterprise/internal/licensing/resolvers
     To resolve, move this package to enterprise/internal/.

  4. cmd/frontend/enterprise
     The following 2 packages import this package across a command boundary.
     	- enterprise/internal/batches
	- enterprise/internal/insights
     To resolve, move this package to enterprise/internal/.

  5. cmd/frontend/envvar
     The following 8 packages import this package across a command boundary.
     	- cmd/repo-updater/shared
	- enterprise/internal/batches/resolvers
	- enterprise/internal/insights/background
	- internal/conf
	- internal/database
	- internal/profiler
	- internal/repos
	- internal/usagestats
     To resolve, move this package to internal/.

  6. cmd/frontend/external
     This package is not accessible to any repository-external project.
     This package is not imported by any binary defined in this repository.
     To resolve, delete this package (not including any existing child package).

  7. cmd/frontend/globals
     The following 5 packages import this package across a command boundary.
     	- cmd/repo-updater/shared
	- enterprise/cmd/repo-updater
	- enterprise/cmd/repo-updater/authz
	- enterprise/internal/database
	- internal/database
     To resolve, move this package to internal/.

  8. cmd/frontend/graphqlbackend
     The following 10 packages import this package across a command boundary.
     	- dev/reconciler-test-script
	- enterprise/internal/batches/resolvers
	- enterprise/internal/batches/resolvers/apitest
	- enterprise/internal/batches/service
	- enterprise/internal/batches/testing
	- enterprise/internal/codemonitors
	- enterprise/internal/codemonitors/resolvers
	- enterprise/internal/codemonitors/storetest
	- enterprise/internal/insights/resolvers
	- enterprise/internal/licensing/resolvers
     To resolve, move this package to internal/.

  9. cmd/frontend/graphqlbackend/externallink
     The following 1 packages import this package across a command boundary.
     	- enterprise/internal/batches/resolvers
     To resolve, move this package to enterprise/internal/.

 10. cmd/frontend/graphqlbackend/graphqlutil
     The following 3 packages import this package across a command boundary.
     	- enterprise/internal/batches/resolvers
	- enterprise/internal/codemonitors/resolvers
	- enterprise/internal/insights/resolvers
     To resolve, move this package to enterprise/internal/.

 11. cmd/frontend/internal/app/assets/gen
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 12. cmd/frontend/internal/app/templates/gen
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 13. cmd/frontend/webhooks
     The following 1 packages import this package across a command boundary.
     	- enterprise/internal/batches/webhooks
     To resolve, move this package to enterprise/internal/.

 14. cmd/gitserver/server
     The following 2 packages import this package across a command boundary.
     	- internal/gitserver
	- internal/vcs/git
     To resolve, move this package to internal/.

 15. cmd/query-runner/queryrunnerapi
     The following 1 packages import this package across a command boundary.
     	- cmd/frontend/graphqlbackend
     To resolve, move this package to internal/.

 16. cmd/searcher/protocol
     The following 2 packages import this package across a command boundary.
     	- cmd/frontend/graphqlbackend
	- internal/search/searcher
     To resolve, move this package to internal/.

 17. cmd/searcher/search
     The following 1 packages import this package across a command boundary.
     	- cmd/frontend/graphqlbackend
     To resolve, move this package to internal/.

 18. dev
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 19. dev/depgraph/lints
     This package is imported exclusively by internal code within dev/depgraph.
     To resolve, move this package into dev/depgraph/internal.

 20. doc/cli/references
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 21. docker-images/prometheus/cmd/prom-wrapper
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 22. enterprise/cmd/frontend/auth
     This package is imported exclusively by internal code within enterprise/cmd/frontend.
     To resolve, move this package into enterprise/cmd/frontend/internal.

 23. enterprise/cmd/frontend/auth/httpheader
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into enterprise/dev/ or enterprise/cmd/.

 24. enterprise/cmd/frontend/authz
     This package is imported exclusively by internal code within enterprise/cmd/frontend.
     To resolve, move this package into enterprise/cmd/frontend/internal.

 25. enterprise/cmd/repo-updater/authz
     This package is imported exclusively by internal code within enterprise/cmd/repo-updater.
     To resolve, move this package into enterprise/cmd/repo-updater/internal.

 26. enterprise/dev/ci/ci
     This package is imported exclusively by internal code within enterprise/dev/ci.
     To resolve, move this package into enterprise/dev/ci/internal.

 27. enterprise/internal/codeintel/autoindex/inference
     This package is used exclusively by frontend.
     To resolve, move this package to enterprise/cmd/frontend/internal/.

 28. enterprise/internal/codemonitors/background
     This package is used exclusively by repo-updater.
     To resolve, move this package to enterprise/cmd/repo-updater/.

 29. enterprise/internal/insights/background
     This package is used exclusively by repo-updater.
     To resolve, move this package to enterprise/cmd/repo-updater/.

 30. enterprise/internal/license
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into enterprise/dev/ or enterprise/cmd/.

 31. enterprise/internal/licensing/resolvers
     This package is used exclusively by frontend.
     To resolve, move this package to enterprise/cmd/frontend/internal/.

 32. enterprise/lib/codeintel/lsif/test/cmd/lsif-validate
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into enterprise/dev/ or enterprise/cmd/.

 33. enterprise/lib/codeintel/lsif/test/cmd/lsif-visualize
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into enterprise/dev/ or enterprise/cmd/.

 34. enterprise/lib/codeintel/semantic/repl
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into enterprise/dev/ or enterprise/cmd/.

 35. internal/buildkite
     This package is used exclusively by ci.
     To resolve, move this package to enterprise/dev/ci/.

 36. internal/cmd/ghe-feeder
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 37. internal/cmd/init-sg
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 38. internal/cmd/precise-code-intel-tester
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 39. internal/cmd/resources-report
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 40. internal/cmd/src-cli-version
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 41. internal/cmd/tracking-issue
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 42. internal/database/schemadoc
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 43. internal/goremancmd
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 44. internal/search/searcher
     This package is used exclusively by frontend.
     To resolve, move this package to cmd/frontend/.

 45. internal/search/streaming
     This package is used exclusively by frontend.
     To resolve, move this package to cmd/frontend/.

 46. internal/version/minversion
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 47. monitoring
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

 48. schema
     This package is a binary entrypoint outside of the expected command root.
     To resolve, move this package into dev/ or cmd/.

Merge request reports