Skip to content

UI: Update how we badge code intelligence results

Warren Gifford requested to merge ef/17582 into main

Created by: efritz

Fixes #17582 (closed). Fixes #18929 (closed). Fixes #18930 (closed). Fixes #18931 (closed).

To (web) reviewers:

The idea here is to extend the Badged<T> type with another field. Where the old definition specifies only an optional BadgeAttachmentRenderOptions, the new definition allows any Badged<T> to also supply a list of aggregableTags, which are opaque strings. These tags are not meant to be displayed per item, but are meant to be aggregated en masse and displayed for a result set (e.g. all results within the same file).

The big change here is the update of the Badged<T> definition and the introduction of Badge. All other changes fall from that in an obvious way.

Screenies:

Screen Shot 2021-03-08 at 3 04 49 PM Screen Shot 2021-03-08 at 3 04 12 PM Screen Shot 2021-03-08 at 3 12 03 PM Screen Shot 2021-03-08 at 3 08 23 PM

TODO:

Merge request reports