Skip to content

WIP: move LineMatch from graphqlbackend to internal/search

Warren Gifford requested to merge master-dry-run/cc/move-results-to-search into main

Created by: camdencheek

As part of implementing select (#18002 (closed)), @rvantonder mentioned potentially moving the result types from graphqlbackend into internal/search. This PR was an attempt at an exploratory change to see how much effort that would take. This PR specifically just moves the LineMatch type into internal/search/results, and creates a new LineMatchResolver that implements the same necessary graphql interfaces as a wrapper around LineMatch.

Right now, I'm mostly looking for opinions on whether this is a high enough priority refactor that I should slot it in now. For estimation purposes, this PR took me about an hour. If this is something worth tackling, I'll convert this to a real PR and ask for a closer review of the changes.

Merge request reports