Skip to content

UI: Fix cache key for document highlights

Warren Gifford requested to merge ef/fix-range-cache into main

Created by: efritz

Fixes #17231 (closed). The issue was in the usage of memoizeObservable, which was producing cache keys such as

git://...schema_validator.go?disableTimeout=false&isLightTheme=true&ranges=[Object object],[Object object],[Object object]

This means that we were caching results regardless of the range values (as long as it had the same number of ranges for a past query. That's why it was so flaky to reproduce. Now, the cache key has the following format:

git://...schema_validator.go?disableTimeout=false&isLightTheme=true&ranges=64:67,88:91,99:102

Merge request reports