codeintel: Change rank behavior for uploads and indexes
Created by: efritz
We were previously using RANK()
to find the relative ordering of the upload and index queues. We should instead use ROW_NUMBER()
so that several index or upload records with the same insertion time don't occupy the same number.
Previously we would have something like (#1
, #1
, #1
, #4
, #4
, #6
, #7
). Now we should have (#1
, #2
, #3
, #4
, #5
, #6
, #7
).
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #17537 (a0865cc) into main (0b9add2) will increase coverage by
0.00%
. The diff coverage is0.00%
.@@ Coverage Diff @@ ## main #17537 +/- ## ======================================= Coverage 51.70% 51.71% ======================================= Files 1717 1717 Lines 85374 85374 Branches 7763 7763 ======================================= + Hits 44145 44147 +2 + Misses 37329 37328 -1 + Partials 3900 3899 -1
Flag Coverage Δ *Carryforward flag go 50.65% <0.00%> (+<0.01%)
integration 30.69% <ø> (ø)
Carriedforward from 0b9add2 storybook 30.34% <ø> (ø)
Carriedforward from 0b9add2 typescript 54.26% <ø> (ø)
Carriedforward from 0b9add2 unit 34.67% <ø> (ø)
Carriedforward from 0b9add2 *This pull request uses carry forward flags. Click here to find out more.
Impacted Files Coverage Δ .../executor-queue/internal/queues/codeintel/queue.go 0.00% <0.00%> (ø)
...prise/internal/codeintel/stores/dbstore/indexes.go 81.75% <ø> (ø)
...prise/internal/codeintel/stores/dbstore/uploads.go 83.14% <ø> (ø)
...rprise/internal/codeintel/stores/dbstore/worker.go 0.00% <ø> (ø)
.../internal/codeintel/resolvers/graphql/locations.go 85.56% <0.00%> (+2.06%)
Please register or sign in to reply