Skip to content

Symbol pages

Warren Gifford requested to merge bl/exp/symbol-pages into main

Created by: beyang

Demo video: https://app.slack.com/client/T02FSM7DL/D02FRPWF5/files/F01JCHUBZMF

Pre-merge TODO

lsif-protocol:

  • Use separate Symbol type, rather than vertex

lsif-go:

sourcegraph:

  • investigate why precise code intel now isn't enabled after lsif upload (but symbols work)
  • find-references link on the symbol page doesn't load unless it's a new window

general:

  • Rewrite git history for correct author attribution
  • From sqs: "hackiest part is the indirection of ExpSymbol in the GQL API. Should probably just reuse Symbol or should be LSIFSymbol not some weird made-up ExpSymbol."

Follow-ups

  • Slowness loading symbols for large projects (e.g., kubernetes)
  • Add back package dependencies (downstream for now)
  • Add back SymbolsStatsSummary.tsx

Merge request reports