Skip to content
Snippets Groups Projects

grafana: Do not sum by high-cardinality {{op}} on alarm-able data

Merged Warren Gifford requested to merge ef/ungroup-metrics into main

Created by: efritz

While I would like to be able to see this data broken down by operation regularly, it's currently interfering with alarm thresholds. See the difference in the graphs below, which query the same time range.

Screen Shot 2020-12-18 at 1 29 24 PM Screen Shot 2020-12-18 at 1 29 33 PM

Merge request reports

Merged by avatar (Jun 23, 2025 4:44pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff a46774b3efce43121b07ce1b5941a6d6853ef50f...ed0aab6fee9769912b19d410a2833df0c499ab9a.

    Notify File(s)
    @bobheadxi monitoring/definitions/executor_queue.go
    monitoring/definitions/frontend.go
    monitoring/definitions/precise_code_intel_indexer.go
    monitoring/definitions/precise_code_intel_worker.go
    @slimsag monitoring/definitions/executor_queue.go
    monitoring/definitions/frontend.go
    monitoring/definitions/precise_code_intel_indexer.go
    monitoring/definitions/precise_code_intel_worker.go
    @sourcegraph/distribution monitoring/definitions/executor_queue.go
    monitoring/definitions/frontend.go
    monitoring/definitions/precise_code_intel_indexer.go
    monitoring/definitions/precise_code_intel_worker.go
  • Created by: codecov[bot]

    Codecov Report

    Merging #16932 (ed0aab6) into main (a46774b) will increase coverage by 0.00%. The diff coverage is n/a.

    @@           Coverage Diff           @@
    ##             main   #16932   +/-   ##
    =======================================
      Coverage   52.27%   52.27%           
    =======================================
      Files        1699     1699           
      Lines       84122    84122           
      Branches     7603     7603           
    =======================================
    + Hits        43973    43975    +2     
    + Misses      36270    36269    -1     
    + Partials     3879     3878    -1     
    Flag Coverage Δ *Carryforward flag
    go 51.36% <ø> (+<0.01%) :arrow_up:
    integration 29.77% <ø> (ø) Carriedforward from a46774b
    storybook 28.68% <ø> (ø) Carriedforward from a46774b
    typescript 54.43% <ø> (ø) Carriedforward from a46774b
    unit 35.10% <ø> (ø) Carriedforward from a46774b

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    .../internal/codeintel/resolvers/graphql/locations.go 85.56% <0.00%> (+2.06%) :arrow_up:
Please register or sign in to reply
Loading