frontend: Instrument our internal http handlers
Created by: ryanslade
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #16907 (2f2fbf8) into main (7b3c57d) will decrease coverage by
0.00%
. The diff coverage is0.00%
.@@ Coverage Diff @@ ## main #16907 +/- ## ========================================== - Coverage 52.29% 52.29% -0.01% ========================================== Files 1699 1699 Lines 84038 84041 +3 Branches 7618 7618 ========================================== - Hits 43947 43946 -1 - Misses 36216 36221 +5 + Partials 3875 3874 -1
Flag Coverage Δ *Carryforward flag go 51.39% <0.00%> (-0.01%)
integration 29.71% <ø> (ø)
Carriedforward from d1122a0 storybook 28.71% <ø> (ø)
Carriedforward from d1122a0 typescript 54.40% <ø> (ø)
Carriedforward from d1122a0 unit 35.02% <ø> (ø)
Carriedforward from d1122a0 *This pull request uses carry forward flags. Click here to find out more.
Impacted Files Coverage Δ cmd/frontend/internal/cli/http.go 0.00% <0.00%> (ø)
...nal/campaigns/resolvers/changeset_apply_preview.go 59.82% <0.00%> (-0.86%)
.../internal/codeintel/resolvers/graphql/locations.go 83.50% <0.00%> (ø)
Created by: ryanslade
SGTM. I wonder if we should do it wrapper per wrapper like in https://k8s.sgdev.org/github.com/sourcegraph/sourcegraph/-/blob/cmd/frontend/internal/cli/http.go#L84-94
Good idea, that's clearer
Please register or sign in to reply