Skip to content
Snippets Groups Projects

db: Handle null external service failure messages

Merged Warren Gifford requested to merge first-null-string into main

Created by: ryanslade

Merge request reports

Merged by avatar (Jul 14, 2025 12:26am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff 190718815407ef4238b56a119bb6c8d04d07a406...d3d1923dc948b3f66b4342ebf9cee364ffa24633.

    Notify File(s)
    @LawnGnome internal/db/external_services.go
    internal/db/external_services_test.go
    @asdine internal/db/external_services.go
    internal/db/external_services_test.go
    @efritz internal/db/basestore/rows.go
    @eseliger internal/db/external_services.go
    internal/db/external_services_test.go
  • Created by: codecov[bot]

    Codecov Report

    Merging #16884 (d3d1923) into main (e10a004) will decrease coverage by 0.00%. The diff coverage is 10.00%.

    @@            Coverage Diff             @@
    ##             main   #16884      +/-   ##
    ==========================================
    - Coverage   52.30%   52.30%   -0.01%     
    ==========================================
      Files        1699     1699              
      Lines       83996    84005       +9     
      Branches     7686     7686              
    ==========================================
    + Hits        43933    43935       +2     
    - Misses      36191    36199       +8     
    + Partials     3872     3871       -1     
    Flag Coverage Δ *Carryforward flag
    go 51.40% <10.00%> (-0.01%) :arrow_down:
    integration 29.69% <ø> (ø) Carriedforward from e10a004
    storybook 28.74% <ø> (ø) Carriedforward from e10a004
    typescript 54.40% <ø> (ø) Carriedforward from e10a004
    unit 35.04% <ø> (ø) Carriedforward from e10a004

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    internal/db/basestore/rows.go 1.56% <0.00%> (-0.26%) :arrow_down:
    internal/db/external_services.go 66.75% <100.00%> (ø)
    .../internal/codeintel/resolvers/graphql/locations.go 85.56% <0.00%> (+2.06%) :arrow_up:
Please register or sign in to reply
Loading