Skip to content
Snippets Groups Projects

repo-updater: remove Lister interface

Merged Warren Gifford requested to merge asdine/remove-lister-interface into main

Created by: asdine

This PR removes the repos.Lister interface which was introduced to deal with tests that needed to mock calls to RepoStore#List. It now uses the internal/db mocks instead.

Merge request reports

Approval is optional

Merged by avatar (Jul 12, 2025 4:53pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff 32d4f91b165ae94f8468d83dd11065bb84fe824e...0c099f305496c8934233d69d7a6f5a0918d0bd33.

    Notify File(s)
    @unknwon enterprise/cmd/repo-updater/authz/integration_test.go
    enterprise/cmd/repo-updater/authz/perms_syncer.go
    enterprise/cmd/repo-updater/authz/perms_syncer_test.go
    enterprise/cmd/repo-updater/main.go
  • Created by: codecov[bot]

    Codecov Report

    Merging #16874 (0c099f3) into main (32d4f91) will not change coverage. The diff coverage is 90.00%.

    @@           Coverage Diff           @@
    ##             main   #16874   +/-   ##
    =======================================
      Coverage   52.27%   52.27%           
    =======================================
      Files        1698     1698           
      Lines       83932    83932           
      Branches     7792     7792           
    =======================================
      Hits        43877    43877           
      Misses      36189    36189           
      Partials     3866     3866           
    Flag Coverage Δ *Carryforward flag
    go 51.37% <90.00%> (ø)
    integration 29.68% <ø> (ø) Carriedforward from 32d4f91
    storybook 28.74% <ø> (ø) Carriedforward from 32d4f91
    typescript 54.40% <ø> (ø) Carriedforward from 32d4f91
    unit 35.03% <ø> (ø) Carriedforward from 32d4f91

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    internal/repos/syncer.go 76.92% <66.66%> (ø)
    cmd/repo-updater/repoupdater/server.go 57.88% <100.00%> (ø)
    enterprise/cmd/repo-updater/authz/perms_syncer.go 42.41% <100.00%> (ø)
Please register or sign in to reply
Loading