web: cleanup CodeExcerpt / CodeExcerpt2 code split

Created by: slimsag

CodeExcerpt2 feels like a particularly bad name for something that is only enabled by developers in the case of:

// Dev flag for disabling syntax highlighting on search results pages.
const NO_SEARCH_HIGHLIGHTING = localStorage.getItem('noSearchHighlighting') !== null

This change renames it to CodeExcerptUnhighlighted and adds documentation to both which describes the difference between the two.

Helps #6992 (closed)

Signed-off-by: Stephen Gutekanst stephen.gutekanst@gmail.com

Created by: codecov[bot]

Codecov Report

Merging #16254 (467a89c) into main (7c3779e) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #16254   +/-   ##
=======================================
  Coverage   52.99%   53.00%           
=======================================
  Files        1649     1649           
  Lines       82524    82524           
  Branches     7393     7325   -68     
=======================================
+ Hits        43736    43743    +7     
+ Misses      34940    34936    -4     
+ Partials     3848     3845    -3     

Flag	Coverage Δ
go	52.53% <ø> (+0.01%)
integration	29.70% <ø> (+0.03%)
storybook	28.02% <0.00%> (ø)
typescript	54.15% <0.00%> (ø)
unit	35.93% <0.00%> (ø)

Impacted Files	Coverage Δ
client/shared/src/components/CodeExcerpt.tsx	96.82% <ø> (ø)
...shared/src/components/CodeExcerptUnhighlighted.tsx	0.00% <ø> (ø)
client/shared/src/components/FileMatchChildren.tsx	73.91% <0.00%> (ø)
cmd/repo-updater/repos/types.go	69.37% <0.00%> (+0.62%)
.../internal/codeintel/resolvers/graphql/locations.go	85.56% <0.00%> (+6.18%)

Created by: slimsag

Codecov is not happy there is 0% test coverage, so these code needs further improvement still, this PR is an improvement and near-zero-risk so I will ignore codecov here.