external_services: use gjson to validate on normalized config

Created by: unknwon

While gjson works with JSON with comments, it would think a field exists even when the field is commented out (bug or feature? ). Instead, we only use it on normalized JSON.

Fixes #16068 (closed)

Created by: codecov[bot]

Codecov Report

Merging #16211 (b4b4b79) into main (441ab2a) will increase coverage by 0.00%. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main   #16211   +/-   ##
=======================================
  Coverage   52.96%   52.96%           
=======================================
  Files        1649     1649           
  Lines       82452    82452           
  Branches     7467     7467           
=======================================
+ Hits        43670    43673    +3     
+ Misses      34935    34933    -2     
+ Partials     3847     3846    -1     

Flag	Coverage Δ		*Carryforward flag
go	52.56% <50.00%> (+<0.01%)
integration	29.14% <ø> (ø)		Carriedforward from 441ab2a
storybook	28.00% <ø> (ø)		Carriedforward from 441ab2a
typescript	53.94% <ø> (ø)		Carriedforward from 441ab2a
unit	35.97% <ø> (ø)		Carriedforward from 441ab2a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
internal/db/external_services.go	66.10% <50.00%> (ø)
cmd/repo-updater/repos/types.go	69.37% <0.00%> (+0.62%)
.../internal/codeintel/resolvers/graphql/locations.go	85.56% <0.00%> (+2.06%)

Created by: sourcegraph-bot

Notifying subscribers in CODENOTIFY files for diff 441ab2a65e3c4cff4338238ef9005ce98f60ea8a...b4b4b7912c164d410b37340abb7305cfc10929a9.

Notify	File(s)
@LawnGnome	internal/db/external_services.go internal/db/external_services_test.go