Make ErrPublishSameBranch a terminal error and don't retry (!15528) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge mrn/reconciler-terminal-errs into main Nov 06, 2020

Created by: mrnugget

This fixes #15373 (closed) by making ErrPublishSameBranch a terminal error that causes the reconciler to not dequeue the changeset again.

It also adds the tiny helper function errcode.IsTerminal (that mirrors other functions in there) and changes the repos.ChangesetNotFoundError to also be a terminal error.

Make ErrPublishSameBranch a terminal error and don't retry

Merge request reports