Skip to content

codeintel: Flatten bundle manager client

Warren Gifford requested to merge ef/flatten-bundle-manager-client into main

Created by: efritz

Collapse the split between the bundle manager client and the bundle client. This distinction will go away as we merge the database/lsifstore/bundle manager interfaces.

Summary of changes (for reviewers):

  • Merge BundleClient and BundleManagerClient. This adds a dumpID parameter on each method of the former and removes the BundleClient method from the latter.
  • Update uses in API layer (trivial)
  • Update tests in API layer (non-trivial). Previously we were able to register mock functions on multiple clients - now that we only have one client instance we have to be able to say a call can be any of a set of function calls. Helper methods were updated appropriately.

Merge request reports