oauth: use service ID + client ID as the provider config ID (!14949) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge jc/oauth-config-id into main Oct 21, 2020

Created by: unknwon

We used to use ServiceID (e.g. https://github.com/) as the unique config ID for a given OAuth provider. However it is possible that two auth providers both pointing to GitHub.com but as two different OAuth applications (e.g. GitHub and GitHub Enterprise Cloud).

This PR uses combination of <service ID>::<client ID> as the unique config ID for a given OAuth provider.

Fixes #14204 (closed)

oauth: use service ID + client ID as the provider config ID

Merge request reports