Skip to content

Clean up extension registry page

Warren Gifford requested to merge registry-extension-cleanup into main

Created by: felixfbecker

Cleans up CSS and accessibility issues I found on the registry page.

  • Tags were not using btn-outline-secondary properly, causing https://github.com/sourcegraph/sourcegraph/pull/14847#issuecomment-712713249
  • Tags were truncated in the DOM, not in CSS, meaning screenreaders would not hear the tag pronounced correctly
  • Icon was announced to screen readers with the data: URL
  • Leftover style in web-content (web-content.scss should not have any area-specific overrides in it, only global styles.)
  • Class names references that don't exist anymore
  • CSS class name referenced in test instead of test-* class
  • React lists were using index as key even though categories are unique

image

Merge request reports