Skip to content

search: only show tour to new users

Warren Gifford requested to merge juliana/14417-tournewusers into main

Created by: limitedmage

I went back and forth with different ways this could be implemented (event log? data from homepage panels which already query the event log?), but eventually I decided on using the daysActiveCount we have available already in localStorage to show other toasts.

Pros:

  • Available locally, no need to do a GraphQL query to get data
  • Very easy to implement, no need to refactor
  • Will show the tour to all new users, even if not logged in (huge win for Cloud)

Cons:

  • Won't show the tour to existing users that have visited Sourcegraph before but have never done a search. Our hope is that the empty homepage panels will provide enough examples for these users.
  • Will show the tour to existing users if they use a new browser/computer

Merge request reports

Loading