Skip to content

don't fail all results on 1 invalid manifest

Warren Gifford requested to merge dont-fail-on-invalid-manifest into master

Created by: sqs

fix #1445 (closed)

Fixes the case where an extension has invalid JSON that fails to unmarshal into the Go type. For example, the following JSON used to cause the entire extension list to fail, but now the error is shown only on the single bad extension:

  "activationEvents": [
    {"language": "foo"}
  ],

(Note that {"language": "foo"} is not a valid entry for that; it should be "onLanguage:foo".)

screenshot from 2018-12-14 16-29-10

Also only returns valid extension JSON from the API.

Merge request reports

Loading