Skip to content

clean up UserArea, UserSettingsProfilePage, user header, updateUser mutation

Warren Gifford requested to merge user-area-cleanup into main

Created by: sqs

This is mostly a cleanup of tech debt.

  • Move the user event log tab into the user settings sidebar. Let's use the tabs (which are quite prominent) in the user area for things that users need in their usual workflow, not for site admin and audit stuff.
  • Make the GraphQL mutation updateUser return a User instead of EmptyResponse so the caller can get the newly updated user in the same query. This is how most of our other mutations work.
  • Clean up the UserArea code: make it a function component, remove needless props, etc.
  • Clean up the page for editing a user's profile.

The GraphQL change is technically a breaking change, but I don't see any usage of the updateUser mutation outside of the app itself. The src CLI does not expose a command for updateUser either.

Merge request reports