Skip to content

Fix useless recurring Percy reviews

Warren Gifford requested to merge tj/percy-flakes into main

Created by: tjkandala

Problem

Percy requests visual review every month for GitCommitNode. The only thing that changes is the timestamp.

Solution

Mock Date.now before running scripts in the flaky integration test, use Date.now in Timestamp.

Possible alternatives

We could mock the entire Date object, either ourselves or with mockdate. There are several other instances in our application in which we construct a new Date with no arguments to get the current time, as opposed to calling Date.now.

Merge request reports