Skip to content

RFC 213: UI changes on sign-in/sign-up form

Warren Gifford requested to merge tj/RFC-213 into main

Created by: tjkandala

Sign up GIFs

Implementation: Add two public endpoints to check for username and email uniqueness. Implement createValidationPipeline to generalize async + sync validation logic for our useEventObservable hook.

Synchronous validation (no loading spinner when errors found client-side)
Asynchronous validation
Username validation (both asynchronous and synchronous)
Password validation (always synchronous)
Register

Third party auth errors

Implementation: Instead of calling http.Error, redirect to /sign-in with the error message as a URL parameter. The client displays an error message + strips URL parameters.

Screenshot from 2020-09-21 19-50-25

TODO for RFC 213

  • - Remove sign out page (separate PR)
  • - Use new redirect func for all errors (implemented on some errors for review)

Merge request reports