Move [enterprise/]cmd/frontend/authz to [enterprise/]internal/authz
Created by: efritz
The cmd/frontend/authz
package is referenced by cmd/frontend
as well as cmd/repo-updater
and internal/db
.
It's weird that a service and/or internal packages would reach into another service's code. There are other instances of this, but will handle them as time permits.
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #12538 into master will increase coverage by
0.05%
. The diff coverage is75.67%
.@@ Coverage Diff @@ ## master #12538 +/- ## ========================================== + Coverage 50.54% 50.59% +0.05% ========================================== Files 1422 1422 Lines 79676 79597 -79 Branches 6635 6607 -28 ========================================== Hits 40273 40273 + Misses 35954 35878 -76 + Partials 3449 3446 -3
Flag Coverage Δ #go 51.99% <75.67%> (+0.07%)
#integration 24.22% <ø> (-0.03%)
#storybook 12.62% <ø> (ø)
#typescript 46.84% <ø> (-0.02%)
#unit 47.23% <75.67%> (+0.05%)
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files Coverage Δ cmd/frontend/auth/user.go 76.81% <ø> (ø)
cmd/frontend/graphqlbackend/access_tokens.go 32.98% <ø> (ø)
cmd/frontend/graphqlbackend/search_results.go 45.38% <ø> (ø)
cmd/frontend/graphqlbackend/site_admin.go 46.57% <ø> (ø)
cmd/frontend/graphqlbackend/user_emails.go 12.50% <ø> (ø)
cmd/frontend/graphqlbackend/users_create.go 46.66% <ø> (ø)
cmd/frontend/internal/app/verify_email.go 0.00% <ø> (ø)
cmd/frontend/internal/auth/userpasswd/handlers.go 6.34% <ø> (ø)
cmd/frontend/internal/httpapi/auth.go 91.07% <ø> (ø)
.../cmd/frontend/internal/authz/resolvers/resolver.go 70.44% <ø> (ø)
... and 21 more Created by: codecov[bot]
Codecov Report
Merging #12538 into master will increase coverage by
0.05%
. The diff coverage is75.67%
.@@ Coverage Diff @@ ## master #12538 +/- ## ========================================== + Coverage 50.54% 50.59% +0.05% ========================================== Files 1422 1422 Lines 79676 79597 -79 Branches 6635 6607 -28 ========================================== Hits 40273 40273 + Misses 35954 35878 -76 + Partials 3449 3446 -3
Flag Coverage Δ #go 51.99% <75.67%> (+0.07%)
#integration 24.22% <ø> (-0.03%)
#storybook 12.62% <ø> (ø)
#typescript 46.84% <ø> (-0.02%)
#unit 47.23% <75.67%> (+0.05%)
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files Coverage Δ cmd/frontend/auth/user.go 76.81% <ø> (ø)
cmd/frontend/graphqlbackend/access_tokens.go 32.98% <ø> (ø)
cmd/frontend/graphqlbackend/search_results.go 45.38% <ø> (ø)
cmd/frontend/graphqlbackend/site_admin.go 46.57% <ø> (ø)
cmd/frontend/graphqlbackend/user_emails.go 12.50% <ø> (ø)
cmd/frontend/graphqlbackend/users_create.go 46.66% <ø> (ø)
cmd/frontend/internal/app/verify_email.go 0.00% <ø> (ø)
cmd/frontend/internal/auth/userpasswd/handlers.go 6.34% <ø> (ø)
cmd/frontend/internal/httpapi/auth.go 91.07% <ø> (ø)
.../cmd/frontend/internal/authz/resolvers/resolver.go 70.44% <ø> (ø)
... and 21 more
Please register or sign in to reply