Skip to content

Add CampaignSpecs & ChangesetSpecs tables, type definitions and campaigns.Store support

Warren Gifford requested to merge campaign-spec-api-v1-new-tables into campaign-spec-api-v1

Created by: mrnugget

Merge target of this PR is https://github.com/sourcegraph/sourcegraph/pull/11675, which will contain the new campaigns workflow and allows us to merge without breaking master.

This is the next step to build up the necessary CRUD pieces and adds:

  • a campaign_specs table, a CampaignSpec type definition and methods in campaigns.Store
  • same goes for ChangesetSpec

The schema is:

  • a campaign can have one campaign_spec
  • a campaign_spec can have many changeset_spec

Most notable is that changeset_specs.campaign_spec_id is nullable so that users can create ChangesetSpecs individually and then attach them to CampaignSpecs.

And both tables have a new rand_id column that contains a short, unguessable text ID that we can use as an external GraphQL node ID for both.

Other than that: this is just the usual boilerplate that we used before. Major difference is that I made the tests a bit cleaner and created separate files (!) which I think we should do for the other tables too. It's far easier to work with.

Merge request reports