Skip to content

docker-images(cadvisor): bake in a set of default args

Warren Gifford requested to merge distribution/cadvisor-image into master

Created by: bobheadxi

This bakes in the set of arguments used to reduce memory usage and prometheus load on our clusters into our cAdvisor image.

There are two additional arguments we use:

-store_container_labels=false -whitelisted_container_labels=io.kubernetes.container.name,io.kubernetes.pod.name,io.kubernetes.pod.namespace,io.kubernetes.pod.uid

opting not to bake these in because they are k8s-specific. From what I understand, adding the args when running will append (not override) flags so this should set the correct flags (inspect seems to imply as much):

docker run -d sourcegraph/cadvisor:dev -store_container_labels=false -whitelisted_container_labels=io.kubernetes.container.name,io.kubernetes.pod.name,io.kubernetes.pod.namespace,io.kubernetes.pod.uid

Will update https://github.com/sourcegraph/deploy-sourcegraph/pull/722, https://github.com/sourcegraph/deploy-sourcegraph-docker/pull/118 with the reduced arg set

Merge request reports

Loading