Skip to content

RFC 113: Implement `PermsFetcher` interface for Bitbucket Server authz provider

Created by: unknwon

Essentially, add two methods to Bitbucket Server authz provider: enterprise/cmd/frontend/internal/authz/bitbucketserver

https://github.com/sourcegraph/sourcegraph/blob/21ebcf76705dff32b5c6573de65e12ab9c5a112d/enterprise/cmd/repo-updater/authz/perms_syncer.go#L45-L62

An example implementation for GitLab can be found at https://github.com/sourcegraph/sourcegraph/blob/master/enterprise/cmd/frontend/internal/authz/gitlab/sudo.go

Things to note

  1. Return partial but valid results whenever possible.
  2. When fetch in user-centric:
    1. Impersonate/fetch via username
    2. The username as the extsvc.ExternalAccountID for results.
  3. When fetch in repo-centric: 2. The repo ID as the extsvc.ExternalRepoID for results. 3. There are two candidate APIs to use: - https://docs.atlassian.com/bitbucket-server/rest/5.16.0/bitbucket-rest.html#idm8297380432 - https://docs.atlassian.com/bitbucket-server/rest/5.16.0/bitbucket-rest.html#idm8283203728 (we have a method for this endpoint already)

Let me know when you have any questions!