Improve search history activation
Created by: benvenker
Successful outcomes of this issue
-
Trigger history on focus (or after 100ms if that's the activation time for the rest of the suggestions) -
When activating with Ctrl + space
, also trigger after 100ms (or whatever the standard suggestion time is), not the current longer wait time -
Support activating search history with Ctrl/Meta + N
-
And support navigating the list downward with Ctrl/Meta + N
and downward withCtrl/Meta + P
-
Background
It takes a long time (feels like almost a second) to activate search history on input focus and when manually activated with Ctrl + space
. The other suggestions activate/can be manually triggered instantly, making the history delay feel slow and inconsistent, especially when manually activated.
By comparison, Google suggestions, which include history items, are displayed instantly when you click in or press down arrow in the input (if they're hidden).
I found this Slack thread which provides some context as to how we got to the current state, but it also seems like what was ultimately landed on was a short (100ms?) delay for showing suggestions when available, not a separate and longer delay exclusively for activating search history, which is what seems to have also been implemented.