Skip to content

Browser extension hovers are broken on GitHub PRs (for Refined GitHub users)

Created by: sqs

It looks like GitHub's PR DOM changed for users of Refined GitHub. See the screenshots in the next comment for the A/B test.

Repro:

  1. Go to a PR, such as https://github.com/gorilla/mux/pull/463/files or https://github.com/sourcegraph/go-diff/pull/21/files, and hover over tokens

Expected: hovers

Actual: no hovers, and error in JS console:

inject.bundle.js:1 Uncaught TypeError: Cannot read property 'getElementsByTagName' of undefined
    at p (inject.bundle.js:1)
    at getDiffCodePart (inject.bundle.js:1)
    at inject.bundle.js:1
    at t.project (inject.bundle.js:1)
    at t._next (inject.bundle.js:1)
    at t.next (inject.bundle.js:1)
    at t.notifyNext (inject.bundle.js:1)
    at t._next (inject.bundle.js:1)
    at t.next (inject.bundle.js:1)
    at t._next (inject.bundle.js:1)