Skip to content
Snippets Groups Projects
Closed Replace calls to git.ExecReader with specific use cases
  • View options
  • Replace calls to git.ExecReader with specific use cases

  • View options
  • Closed Issue created by Warren Gifford

    Created by: ryanslade

    Instead of calling directly into git.ExecReader, we should instead call into functions that show the intent.

    For example: https://github.com/sourcegraph/sourcegraph/blob/main/enterprise/cmd/frontend/internal/codeintel/resolvers/position.go#L126

    We should instead be calling a function named something like git.ReadDiffHunks.

    Once all calls are changed, remove git.ExecReader

    Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first