Buttons contributed to the extensions toolbar should allow to specify "toggled" state
Created by: felixfbecker
Many buttons contributed to the toolbar are to toggle something on or off, e.g. Coverage colors, soon code intel, ... The on/off state can currently only be communicated through the label "Enable"/"Disable". This makes it impossible to omit the lable to save space, and looks very weird on GitHub where the buttons look like actual 3D buttons, that don't change into a "pressed" state when the setting is enabled.
There should be a field "toggled"
in package.json for the button that is a boolean expression (and can read a setting for example) that makes the button toggled or not. On the Sourcegraph webapp, the state could be indicated by a background color change (something like rgba(0, 0, 0, 0.5)
in light theme, rgba(255, 255, 255, 0.5)
in dark theme).
I see this as a prerequisite to add an enable/disable for TypeScript because otherwise the experience is very weird.
Rel #1572 (closed)