Slow blank search performance
Created by: krishicks
- Sourcegraph version: Sourcegraph.com
- Platform information: macOS 10.14, Firefox 63
Steps to reproduce:
- Go to any repository on sourcegraph.com, e.g. https://sourcegraph.com/github.com/krishicks/yaml-patch
- Click on the downward-facing triangle button next to the repository name
Expected behavior:
Since nothing is typed, nothing (no spinner, or results) is shown. or Since nothing is typed, 10 random repositories are shown as quickly as results are returned or Since nothing is typed, the first 10 repositories in alphabetical order are shown as quickly as results are returned when performing a search with a non-empty query (for me, ~175ms).
Actual behavior:
The spinner spins for about 9-10 seconds before showing anything, delivering a poor user experience. I wasn't sure if I was supposed to just start typing or not, then 10 seconds later I saw some random results.
Notably, the results are not cached, so each click of the button causes another 9-second request to be made.
It's not clear to me if this is a route towards a DOS; I did not hammer the button enough to find out.
In any event, I think it could be improved to not be a slow (and potentially service-disrupting) query, and also give the user a better experience.