Navigation updates, Code Security name change
Created by: zlonko
This closes #5266 (closed). It updates navigation in the header to expose use cases and reflect the renamed Code Security page. Links are also updated to support Code Security and the removal of the Product Specialist page, a.k.a. "Become One".
Specs are located in this doc.
Changelog
- Restructured the desktop and mobile dropdowns for "Customers" in
Header
- Renamed dropdown to "Use Cases"
- Removed links to
/use-cases
and/product-specialist
- Added links for the five use case pages
- Flipped order of "Case Studies" and "Use Cases" in
Footer
- Deleted
product-specialist.tsx
per specs- Added redirect from
/contact/product-specialist
to/demo
- Changed in-repo links to this page to
demo
- Added redirect from
- Updated "Fixing Vulnerabilities" to "Code Security"
- Renamed
vulnerabilities.tsx
tocode-security.tsx
- Updated meta on
code-security.tsx
- Changed in-repo links and added redirect from
/use-cases/vulnerabilities
to/use-cases/code-security
- Updated anchor link on
/use-cases
- Renamed
Bug Fixes
- The mobile navs on Batch Changes and Code Reuse were invisible, so those have been fixed
- Code Insights was added back into the nav on this issue: https://github.com/sourcegraph/about/issues/5391
Notes
- Re: Linking the Use Case dropdown header to
/use-cases
-
react-bootstrap doesn't appear to support adding an href on NavDropdown: docs
-
This also seems to pose a usability issue: a user could click the header wanting to expand the menu, but end up following the link (or vice versa). Also, a user may not expect this behavior, because neither the Product nor Resource dropdowns will repeat this pattern. Perhaps it is more declarative to have another nested item for "All Use Cases"? For example:
-
Test
- Ensure linting passes.
- Ensure prettier has standardized the proposed changes.
- Ensure dev and production builds work.
- Please check that the nav links under the "Use Case" dropdown work as expected on mobile and desktop
- Navigate to
/use-cases/code-security
successfully - Check that anchor links on
/use-cases
are intact - Please test redirects for
/product-specialist
and/use-cases/vulnerabilities