Skip to content

search: refactor parse-check-validate pipeline and alerts

Warren Gifford requested to merge rvt/separate-parse-and-check into master

Created by: rvantonder

Goals:

  • Start implementing the pipeline where we do parse -> check (AST) -> validate (legal search queries). See RFC 75 for reference.
  • Each stage in the pipeline promotes errors to friendly alerts that surface on the client side
  • Get rid of didYouMeanQuotedResolver. Use searchAlert to surface the alerts and suggestions for this logic. I removed most of this and migrated into the pipeline for alerts, and then migrated the tests into search_test.go

I will do more moving things around but don't want to create rebase hell with the other outstanding PRs.

Merge request reports