Skip to content

fix: code intel broken on diffs with newly added files

Warren Gifford requested to merge code-intel-diffs into master

Created by: attfarhan

PR from https://github.com/sourcegraph/browser-extensions/pull/294

This PR changes:

Fixes sourcegraph/sourcegraph#605

This blue border on newly added files in diffs counted as a row, and since it doesn't have any class names, it isn't filtered out in isCode. Hence, we can't assume that line is non-null.

image

Testing plan:

I've tested on this PR: https://github.com/sourcegraph/sourcegraph/pull/586/files. The browser extension would break once scrolling past licenseusercount.go. I confirmed this PR fixes the issue so code intel works.

This PR updates the CHANGELOG.md file to describe any user-facing changes. This PR does not need to update the CHANGELOG because ...

Merge request reports