Skip to content

batches: hide scrollbar on tab bar

Warren Gifford requested to merge kr/no-scrollbar-pls into main

Created by: courier-new

Closes https://github.com/sourcegraph/sourcegraph/issues/39808.

Gets rid of the weird border line underneath the 4 steps tab bar on the Batch Change "create" page and SSBC workflow pages, which turned out to be a disabled scrollbar.

Before After
Screen Shot 2022-08-19 at 6 42 39 PM Screen Shot 2022-08-19 at 6 43 11 PM

To answer your inevitable questions about this change:

  • No, I don't know why we had this set to scroll originally. There's no good reason to ever set overflow: scroll.
  • No, I don't know why Randell/Daniel saw the scrollbar in any browser, at any window size but Erik and myself didn't see it in any browser, at any window size. Best guess is that it's a manifestation of a MacOS "automatic" scrollbar setting behaving differently on different machines.

In short, 🤷‍♀️

Test plan

  1. Be Randell/Daniel. Or if you're not so blessed, on MacOS, go to System Preferences > General and set scrollbar visibility to "Always"
  2. Visit /batch-changes/create
  3. Observe lack of scrollbar 👍
  4. Resize window width until the tabs no longer fit
  5. Observe scrollbar 👍

App preview:

Check out the client app preview documentation to learn more.

Merge request reports