Skip to content

simple ui: combine search info dropdown and query time/results count

Warren Gifford requested to merge jp/infobarprogresssimple into main

Created by: limitedmage

Fixes #38670 (closed)

Review notes

Please review commit by commit, I've tried to make each commit an atomic change and add good commit messages. Also review with "show whitespace" off.

Changes

For all cases of the search progress/skipped results dropdown:

  • If tracing is on (URL contains &trace=1), "Show trace" button is now shown after the skipped results dropdown button instead of before

When coreWorkflowImprovementsEnabled is on:

  • Search progress count with animation is now only shown when search is in progress
  • Skipped results dropdown button is now only shown when search is complete
  • Skipped results dropdown button now shows the count instead of generic text
  • Skipped results dropdown popover now shows details on the count

image

Test plan

Updated storybook tests for StreamingProgress to include with and without coreWorkflowImprovementsEnabled

  • Only visual change without it on should be moving the "Show trace" button to the end

App preview:

Check out the client app preview documentation to learn more.

Merge request reports